sparsick commented on code in PR #412:
URL:
https://github.com/apache/maven-build-cache-extension/pull/412#discussion_r2578666191
##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -260,13 +281,14 @@ private CacheRestorationStatus restoreProject(
cacheCandidate.getMojoDescriptor().getFullGoalName());
// need maven 4 as minumum
// mojoExecutionScope.seed(
- // org.apache.maven.api.plugin.Log.class,
- // new DefaultLog(LoggerFactory.getLogger(
- //
cacheCandidate.getMojoDescriptor().getFullGoalName())));
+ // org.apache.maven.api.plugin.Log.class,
+ // new DefaultLog(LoggerFactory.getLogger(
+ // cacheCandidate.getMojoDescriptor().getFullGoalName())));
Review Comment:
the commented code has a comment that it is related to mvn4. Therefore, we
don't delete it. Is it okay, @sebtiem, if we delete the commented code? (`git
blame` give me your name).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
