slawekjaranowski commented on code in PR #1441:
URL: https://github.com/apache/maven-release/pull/1441#discussion_r2572568384
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -113,7 +113,7 @@ public void executeGoals(
targetGoals.add(additionalArguments);
}
- req.setGoals(targetGoals);
+ req.addArgs(targetGoals);
Review Comment:
It is not a good idea. Each argument passed to `setGoals` are internal
parsed, escaped and so on ...
but `addArgs` pass arguments as is to command line process
look at line 113 `additionalArguments` is add as one item to list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
