marko-bekhta commented on code in PR #1281:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/1281#discussion_r2509303426
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -2789,6 +2805,38 @@ private Optional<File> getAddStylesheet(final File
javadocOutputDirectory, final
"additional stylesheet file does not exist: " +
addstylesheetfile.getAbsolutePath());
}
+ private void addAddScripts(List<String> arguments) throws
MavenReportException {
+ if (addScripts == null) {
+ return;
+ }
+
+ for (String addScript : addScripts) {
Review Comment:
`addArgIfNotEmpty(` had that check to produce a warning, but as you've
suggested. I added a check and exception just above ^.
thanks 🙂
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -2789,6 +2805,38 @@ private Optional<File> getAddStylesheet(final File
javadocOutputDirectory, final
"additional stylesheet file does not exist: " +
addstylesheetfile.getAbsolutePath());
}
+ private void addAddScripts(List<String> arguments) throws
MavenReportException {
+ if (addScripts == null) {
+ return;
+ }
+
+ for (String addScript : addScripts) {
Review Comment:
`addArgIfNotEmpty(` had that check to produce a warning, but as you've
suggested... I added a check and exception just above ^.
thanks 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
