cstamas commented on issue #1646:
URL: 
https://github.com/apache/maven-resolver/issues/1646#issuecomment-3476394693

   And right, the difference before and after commit is obvious: the "old" 
`FilteringDependencyVisitor` calls filter with `parents`, while 
`AbstractDependencyNodeConsumerVisitor` with full path (self included). This 
obviously violates the context explained on `DependencyFilter`:
   
   ```
       /**
        * Indicates whether the specified dependency node shall be included or 
excluded.
        *
        * @param node The dependency node to filter, must not be {@code null}.
        * @param parents The (read-only) chain of parent nodes that leads to 
the node to be filtered, must not be
        *            {@code null}. Iterating this (possibly empty) list walks 
up the dependency graph towards the root
        *            node, i.e. the immediate parent node (if any) is the first 
node in the list. The size of the list also
        *            denotes the zero-based depth of the filtered node.
        * @return {@code true} to include the dependency node, {@code false} to 
exclude it.
        */
       boolean accept(DependencyNode node, List<DependencyNode> parents);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to