olamy commented on code in PR #394:
URL:
https://github.com/apache/maven-build-cache-extension/pull/394#discussion_r2480711589
##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -244,6 +266,7 @@ private CacheRestorationStatus restoreProject(
// Restore project artifacts
ArtifactRestorationReport restorationReport =
cacheController.restoreProjectArtifacts(cacheResult);
+
Review Comment:
not needed
##########
pom.xml:
##########
@@ -427,6 +428,17 @@ under the License.
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
+ <java>
+ <palantirJavaFormat>
+ <version>2.81.0</version>
Review Comment:
why do we need this here? It should come from parent pom
##########
src/main/java/org/apache/maven/buildcache/LifecyclePhasesHelper.java:
##########
@@ -182,6 +182,7 @@ private String
resolveMojoExecutionLifecyclePhase(MavenProject project, MojoExec
public List<MojoExecution> getCachedSegment(MavenProject project,
List<MojoExecution> mojoExecutions, Build build) {
List<MojoExecution> list = new ArrayList<>(mojoExecutions.size());
for (MojoExecution mojoExecution : mojoExecutions) {
+
Review Comment:
not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
