AlexanderAshitkin commented on code in PR #394:
URL:
https://github.com/apache/maven-build-cache-extension/pull/394#discussion_r2423018495
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -498,25 +498,23 @@ public void save(
final MavenProject project = context.getProject();
final MavenSession session = context.getSession();
try {
+ attachedResourcesPathsById.clear();
Review Comment:
it is a shared field and, potentially, could be accesses by different
threads in a multithreaded session. It looks like a racy piece and HashMap
might be not the best choice here. overall, elaborate please - why need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
