olamy commented on code in PR #388:
URL:
https://github.com/apache/maven-build-cache-extension/pull/388#discussion_r2404847324
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -575,7 +575,24 @@ public String getLocalRepositoryLocation() {
public List<DirName> getAttachedOutputs() {
checkInitializedState();
final AttachedOutputs attachedOutputs =
getConfiguration().getAttachedOutputs();
- return attachedOutputs == null ? Collections.emptyList() :
attachedOutputs.getDirNames();
+ if (attachedOutputs == null) {
+ return getDefaultAttachedOutputs();
+ }
+ return attachedOutputs.getDirNames();
+ }
+
+ private List<DirName> getDefaultAttachedOutputs() {
Review Comment:
I agree; the most important thing here is CI working first, then cli and
then potentially ide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
