Pankraz76 commented on code in PR #11284:
URL: https://github.com/apache/maven/pull/11284#discussion_r2436639005
##########
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##########
@@ -533,16 +533,16 @@ private String toStringObject() {
}
private static <T> boolean addToStringField(
- StringBuilder sb, T o, Function<T, Boolean> p, String n,
boolean w) {
Review Comment:
idk whats happening here. Thats a good example why not to use single char
variables. Considering this API broken as its not telling the intent right away.
##########
compat/maven-model/src/test/java/org/apache/maven/model/v4/ModelXmlTest.java:
##########
@@ -56,19 +56,20 @@ void testXmlRoundtripWithProperties() throws Exception {
@Test
void testNamespaceInXmlNode() throws XMLStreamException {
- String xml = "<project
xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n";
- + " xmlns=\"http://maven.apache.org/POM/4.0.0\"\n";
- + "
xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0
http://maven.apache.org/POM/4.0.0\";>\n"
- + " <build>\n"
- + " <plugins>\n"
- + " <plugin>\n"
- + " <m:configuration
xmlns:m=\"http://maven.apache.org/POM/4.0.0\";
xmlns=\"http://fabric8.io/fabric8-maven-plugin\";>\n"
- + " <myConfig>foo</myConfig>\n"
- + " </m:configuration>\n"
- + " </plugin>\n"
- + " </plugins>\n"
- + " </build>\n"
- + "</project>";
+ String xml = """
Review Comment:
IDE suggestion. Can not read this without text block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
