AlexanderAshitkin commented on code in PR #389: URL: https://github.com/apache/maven-build-cache-extension/pull/389#discussion_r2423082754
########## src/main/resources/default-reconciliation/defaults.xml: ########## @@ -0,0 +1,54 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<!-- + Default reconciliation configurations for common Maven plugins. + These configurations are applied automatically when no explicit executionControl is configured. +--> +<defaults xmlns="http://maven.apache.org/DEFAULT-RECONCILIATION/1.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/DEFAULT-RECONCILIATION/1.0.0 default-reconciliation.xsd"> + + <!-- maven-compiler-plugin:compile - track source, target, release --> + <plugin> + <artifactId>maven-compiler-plugin</artifactId> + <goal>compile</goal> + <properties> + <property>source</property> Review Comment: Considering that this change has categorized the parameters of the `maven-compiler-plugin`, do we really need this config? Wouldn't it be simpler to use the newly created `maven-compiler-plugin.xml` for default reconciliation? This approach would be more accurate. And if someone wants to relax the defaults, it is possible to do on a project config level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
