AlexanderAshitkin commented on code in PR #389:
URL:
https://github.com/apache/maven-build-cache-extension/pull/389#discussion_r2404731818
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -248,18 +248,15 @@ public boolean isLogAllProperties(MojoExecution
mojoExecution) {
}
private GoalReconciliation findReconciliationConfig(MojoExecution
mojoExecution) {
- if (cacheConfig.getExecutionControl() == null) {
- return null;
- }
+ List<GoalReconciliation> reconciliation;
- final ExecutionControl executionControl =
cacheConfig.getExecutionControl();
- if (executionControl.getReconcile() == null) {
- return null;
+ if (cacheConfig.getExecutionControl() == null ||
cacheConfig.getExecutionControl().getReconcile() == null) {
Review Comment:
What if `executionControl` is present but does not include the compiler
plugin? I would expect that the default reconciliation parameters for this
plugin are still used.
##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -271,6 +268,56 @@ private GoalReconciliation
findReconciliationConfig(MojoExecution mojoExecution)
return null;
}
+ private List<GoalReconciliation> getDefaultReconciliationConfigs() {
Review Comment:
That's a good idea. The only consideration here, is that extending this list
may not be elegant. Storing an XML file for each plugin as a classpath resource
would be easier to read and maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
