ls-urs-keller commented on code in PR #1428:
URL: https://github.com/apache/maven-mvnd/pull/1428#discussion_r2390151443
##########
.github/workflows/early-access.yaml:
##########
@@ -156,6 +157,27 @@ jobs:
ld -r /lib/x86_64-linux-gnu/Scrt1.o
client/target/dynamic-libc-start.o -o
client/target/graalvm-libs-for-glibc-2.12/Scrt1.o
objcopy --redefine-syms=client/src/main/resources/glibc/glibc.redef
client/target/graalvm-libs-for-glibc-2.12/Scrt1.o 2>/dev/null
+ - name: '(arm64) Patch GraalVM libs for only requiring glibc 2.12'
+ if: ${{ env.OS == 'linux' && env.ARCH == 'aarch64' }}
+ shell: bash
+ run: |
+ mkdir -p client/target/graalvm-libs-for-glibc-2.12
+
+ : patch common libraries
+ ( find "$GRAALVM_HOME/lib/static/linux-aarch64/glibc" -name '*.a'
+ ls -1 /lib/aarch64-linux-gnu/libz.a
Review Comment:
Appreciate this PR. You could use something like `$(arch)` instead of
aarch64 or x86_64. This way this code can be the same as the one for x86_64.
E.g.
```bash
$ docker run --platform linux/arm64 -ti alpine arch
aarch64
$ docker run --platform linux/amd64 -ti alpine arch
x86_64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
