jira-importer commented on issue #282: URL: https://github.com/apache/maven-war-plugin/issues/282#issuecomment-2967858295
**[Stephane Nicoll](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=snicoll)** commented Sorry Olivier, I finally had the time to look into details before calling a vote for 2.1-alpha-1 and there is a couple of problems. 1. Missing overlay's type There is no way to define the type of the overlay so your implementation takes the assumption that there will be no clash between war artifacts and zip artifacts. I know it sounds a bit tricky but we should stick to the dependency mechanism properly. So we should add a "type" attribute for the overlay and retrieve the Artifact in the OverlayManager using this property **which defaults to war** (hence, for a war, there is no type attribute to set). 2. Zip handling I don't like your implementation when you update the "this.overlays" list. This list should not be updated there, it's the best way to have inconsistencies when we'll upgrade the code. I understand that you had to do this to disable the behavior by default. 1 is a must have because if we do it later, it will break for users updating (type will suddenly be necessary for zip overlays). If you are conformable with the idea and have time, do it. If you don't, I'll do it but I have a real free time issue now I'm teaching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
