jira-importer commented on issue #282:
URL: 
https://github.com/apache/maven-war-plugin/issues/282#issuecomment-2967858242

   **[Tuomas 
Kiviaho](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tuomas_kiviaho)**
 commented
   
   Thanks in advance,
   
   I hope this clarifies the remark a bit. Zip overlays a.k.a zip dependencies 
as overlays could be disabled by default for backward compatibility, but 
enabling it isn't in my opinion ideal if there is a zipOverlays=true/false 
property. What about other overlays in the future (tar.gz etc. whatever 
ArchiveManager can handle). There is currently at least 
dependentWarIncludes/dependentWarExcludes configuration parameters suffering 
from similar tight coupling with the packaging in hand. Something like 
overlayTypes="The comma separated list of types to overlay in the WAR. Default 
is 'war'." could be generic enough and gives possibilities to tie 
ArchiveManager in to implementation making overlaying type agnostic.. For me 
choosing the most generic configuration approach in the big picture is more 
important than just having the patch applied, but having a working patch would 
be highly appreciated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to