jira-importer commented on issue #257:
URL: 
https://github.com/apache/maven-war-plugin/issues/257#issuecomment-2967856378

   **[Jochen 
Wiedmann](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jochen.wiedm...@gmail.com)**
 commented
   
   The reason for this bug is in the use of the "CompositeMap" for filtering. 
The "CompositeMap" is basically a special Map, which works like this:
   
   - Query the Project in a "magic" way for the property. If something non-null 
is returned, that's the result value.
   - Otherwise, query the projects properties and return the result.
   
   The "magic" way is implemented by a utility class called 
ReflectionValueExtractor. The first thing this class does is removing any part 
of the property name until and including a dot. In other words, the lookup for 
"something.url" becomes a lookup for "url". That's of course a valid value. In 
other words, a possible workaround is to change your property name to 
"something_url" and everything should work fine.
   
   I find the behaviour of ReflectionValueExtractor (or the use of it) quite 
questionable. Basically this means that ${whatever.foo} becomes ${project.foo}. 
In other words, the use of the dot (which is quite common if not recommended in 
property names) becomes almost imopssible.
   
   I'd recommend to
   
   - change the implementation of CompositeMap so that it accepts an array of 
Maps, rather than two Maps.
   
   - Instantiate the CompositeMap with the following values, in that order:
   
     project.getProperties()
     ReflectionMap(project)
     System.getProperties()
   
   I am ready to provide a patch, should I know that my suggestion will be 
accepted.
   
   my re
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to