jira-importer commented on issue #191:
URL: 
https://github.com/apache/maven-war-plugin/issues/191#issuecomment-2967849190

   **[Ernesto S. Tolentino 
Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** 
commented
   
   While debugging through maven-war-plugin, I noticed that 
project.getArtifacts() did not include the artifacts with system scope. This 
means that adding:
   
       public void buildWebapp( MavenProject project, File webappDirectory )
           throws MojoExecutionException, IOException
       {
               ...
               ScopeArtifactFilter runtimeFilter = new ScopeArtifactFilter( 
Artifact.SCOPE_RUNTIME );
               ScopeArtifactFilter systemFilter = new ScopeArtifactFilter( 
Artifact.SCOPE_SYSTEM );
               if ( !artifact.isOptional() && ( runtimeFilter.include( artifact 
) || systemFilter.include( artifact ) ) )
               ...
       }
   
   won't work. There are two options to solve this:
   
   1. Modify Maven 2 core to include artifacts in project.getArtifacts()
   2. Go through the dependency list and individually fetch the artifacts with 
system scope.
   
   #2 is a more complicated solution because we have to check through the 
inclusions/exclusions list and won't reuse existing framework to properly 
filter artifacts. There is also duplication in the code.
   
   #1 however won't be in time for the Maven 2.0.3 release because the versions 
to be included in that release is already decided on.
   
   I suggest we move this issue to the next release.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to