jira-importer commented on issue #179: URL: https://github.com/apache/maven-war-plugin/issues/179#issuecomment-2967848174
**[Karl Heinz Marbaise](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=khmarbaise)** commented I have taken a look at the patch. First i would name the property not `maven.deploy.skip` i would name it `maven.war.skip` otherwise users will mistaken with other plugins apart from that maven-war-plugin does not really do the deployment. I would suggest to implement the skip like this: ```java if ( skip ) { getLog().info( "WAR generation is skipped." ); return; } ``` Furthermore it would be nice having an integration tests which shows the intendant behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
