jira-importer commented on issue #95:
URL: 
https://github.com/apache/maven-war-plugin/issues/95#issuecomment-2967841971

   **[Edwin 
Punzalan](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elpunzalan)**
 commented
   
   Fabrice,
   
   I tested if the bug exists first before I go and look at the source.  And 
when I did test the bug (after the submitted fix), warSourceExcludes is working 
properly for the **/lib/\*.\* value.  That's when I said the bug seemed fixed 
already.
   
   Anyway, looking at the source, i see that you are correct that #getExcludes 
is inside copyResources.  But please note that #copyResources is done only on 
the webapp directory... and lib is not in it.  This is the reason why during my 
tests does not fail.
   
   Also, looking at the m1 source, m1 is also applying the war.src.excludes 
both to the war file and the resources.  So the port from m1 to m2 is still 
correct.
   
   Btw, I tested again the configuration on 2.0-beta-2 and its working... the 
archive does not have anything inside lib but the WEB-INF/lib directory outside 
the archive has them all.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to