jira-importer commented on issue #95:
URL: 
https://github.com/apache/maven-war-plugin/issues/95#issuecomment-2967841976

   **[Fabrice 
Bellingard](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=fabemn)**
 commented
   
   Hi Edwin,
   
   I'm getting confused for it seems that we don't understand each other: the 
actual problem is that the final War archive has **no** JARs in its WEB-INF/lib 
folder, which is definitely not correct because a WAR must contain the libs it 
depends on (if not, the web application can't be run, right?).
   
   My use case is the following:
   1- I check out a project from CVS: this project has JARs in its WEB-INF/lib 
folder because developers put them in the SCM. But some of those JARs may be 
unused (even if not removed from CVS). Only the POM can tell which JARs the 
project really depends on.
   2- I want to build the WAR with "m2 package". In the final WAR archive, I 
don't want to have the unused JARs, but only the ones referenced in the POM.
   - With m1, when I build my project, the "war.src.excludes" property excludes 
the JARs that where checked out from CVS, and does not exclude the JARs that 
are copied from the local repo to be included in the War. And that's exactly 
what I expect this property to do!
   - But in m2, because #getExcludes is used in #performPackaging, the JARs 
previously copied from the local repo to be put in the WAR are also excluded 
from the War! Which I don't want, of course (a WAR archive needs its libs to be 
able to work properly!). So 'warSourceExcludes' should normally be used only in 
#copyResources (because it is meant to exclude files from the WAR **source**), 
but not in #performPackaging (because at that stage, the MOJO has copied from 
local repo the JARs corresponding to the dependencies defined in the POM, and I 
don't want the MOJO to exclude such files which are not **sources**).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to