[ 
https://issues.apache.org/jira/browse/SCM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961533#comment-17961533
 ] 

ASF GitHub Bot commented on SCM-436:
------------------------------------

jira-importer commented on issue #659:
URL: https://github.com/apache/maven-scm/issues/659#issuecomment-2964611675

   **[Dan 
Tran](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dantran)** 
commented
   
   FileSet do have some meaning with Export api
   
       /**
        * Create an exported copy of the repository on your local machine
        *
        * @param repository the source control system
        * @param fileSet    the files are copied to the {@link 
org.apache.maven.scm.ScmFileSet#getBasedir()} location
        * @return
        * @throws ScmException if any
        */
       ExportScmResult export( ScmRepository repository, ScmFileSet fileSet )
           throws ScmException;
   
   so I we cant not get rid of it.  I will put it back supporting 
workingDirectory at Export command level.  However at Plugin level, there is no 
need to passing exportDirectory
   




> Remove setting working directory in export command api. Working directory has 
> no meaning to export command
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SCM-436
>                 URL: https://issues.apache.org/jira/browse/SCM-436
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-api
>    Affects Versions: 1.1
>            Reporter: Dan Tran
>            Assignee: Dan Tran
>            Priority: Major
>
> Currently maven-scm-plugin set workingDirectory using the given 
> exportDirectory which is wrong since it is not necessary the exportDirectory 
> will be available at command execution  time. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to