[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963521#comment-17963521
]
ASF GitHub Bot commented on SCM-885:
------------------------------------
jira-importer commented on issue #1116:
URL: https://github.com/apache/maven-scm/issues/1116#issuecomment-2964646671
**[Matthieu
Brouillard](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mcfoggy)**
commented
With the patch it is clear that calling
GitChangeLogCommand#createCommandLine() with a null startVersion will not
result anymore in issuing the git log command `..EndVersion` and thus will not
result anymore in being interpreted by `HEAD..EndVersion`.
But still, the ones who will want to retrieve the log between HEAD and
EndVersion will be able to do so by explicitly use "HEAD" as the start version.
Additionaly the ones, like me, expecting to be able to query the log between
the initial commit (unknown/null startVersion) of a repository and a given
commit (even HEAD) can do it.
Instead of changing the interpretation like the patch does perhaps that you
prefer a new API to allow to query from the origin(first commit). This way the
enhancement will be backward compatible (even if non intuitive IMHO).
The use case for me is that we have a maven-plugin (that delegates to
maven-scm API) to compute between two calls what has changed in term of commits
on a project. But the first time we query the log we have no initial commit
(thus starVersion null) and we want the log between the inital commit and HEAD.
> Extend GitChangeLogCommand by using revision only
> -------------------------------------------------
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Improvement
> Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
> Affects Versions: 1.9.5
> Reporter: Matthieu Brouillard
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.10.0
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
