[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963531#comment-17963531
 ] 

ASF GitHub Bot commented on SCM-885:
------------------------------------

jira-importer commented on issue #1116:
URL: https://github.com/apache/maven-scm/issues/1116#issuecomment-2964646705

   **[Matthieu 
Brouillard](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mcfoggy)**
 commented
   
   > The usecase ..END is covered by START..END where START hast to be provided 
as HEAD explicitly
   
   you refused the initial PR that was assuming the same for both `..END` & 
`START..` because it was introducing a non compatible change. I do not 
understand anymore.
   
   > The last usecase for is that SCM_VERSION is END_SCM_VERSION, I'd expect 
users to provide HEAD to avoid ambiguity.
   
   I don't understand the sentence. Given the table above there is no ambiguity 
anymore because if any of the `START_SCM_VERSION` or `END_SCM_VERSION` is 
provided then it is the syntax `A..B` that will be used even if any of A or B 
is ommited (null).
   
   `git whatchanged VERSION` will only be issued when and only when both 
`START_SCM_VERSION` and `END_SCM_VERSION` are null
   
   I'll provide another PR that implements the table.
   




> Extend GitChangeLogCommand by using revision only
> -------------------------------------------------
>
>                 Key: SCM-885
>                 URL: https://issues.apache.org/jira/browse/SCM-885
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Improvement
>          Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
>    Affects Versions: 1.9.5
>            Reporter: Matthieu Brouillard
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.10.0
>
>         Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to