jira-importer commented on issue #558:
URL: https://github.com/apache/maven-scm/issues/558#issuecomment-2964603987

   **[Michael 
Glauche](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mglauche)**
 commented
   
   The getCvsRootForCvsPass is wrong, because it is ok to have a CVSROOT 
without a username in it, so the exception should not be raised. Furthermore, 
the getCvsRootWithCorrectUser method does correctly handle null usernames, so 
the ifNull check is not needed (and is the cause of this bug!)
   
   scm-350.patch does remove the ifNull check and the Exception, so the correct 
CVSROOT without any username/password is returned.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to