[ 
http://jira.codehaus.org/browse/MECLIPSE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114539
 ] 

Richard van Nieuwenhoven commented on MECLIPSE-172:
---------------------------------------------------

yes thats true, but with MECLIPSE-344 and the workspace location know it not 
that difficult, just wrote a good working version based on MECLIPSE-344!

The only problem is ...  test cases ....  because eclipse writes absolute paths 
in its configuration files, and some of the files are binary. That makes 
writing a 
MOCK workspace directory for testing rather difficult. but possible.

IMPORTANT: Could you people here send me your 
".metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.launching.prefs"
 files and the maven-compiler-plugin configuration from your pom,xml that way i 
can write a representative test case.

Arnaud: Could you move the WorkspaceConfiguration bean class from the 
writer.workspace package to the plugin ide package (i do not know how to do 
that in a patch). This way i can reuse it for a workspace reader!

> Don't add Default ClasspathContainer if a alternate JRE or a "Execution 
> Environment" is configured as ClasspathContainer.
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-172
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-172
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2, 2.3
>         Environment: Maven 2.0.4,  Eclipse 3.2.1, Windows XP
>            Reporter: Markus Grieder
>            Assignee: Arnaud Heritier
>             Fix For: 2.5
>
>         Attachments: EclipsePlugin.java.patch, 
> MECLIPSE-172-fix-and-test.patch, patch.txt
>
>
> If have a Eclipse Workspace with Projects where some use Java 1.5 (Default 
> JRE) and some Java 1.3
> For 1.3-Projects i have configured the following ClasspathContainer:
> <classpathContainers>                 
> <classpathContainer>org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/server_jre</classpathContainer>
> </classpathContainers>
> This generates in ".classpath":
> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
> <classpathentry kind="con" 
> path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/server_jre"/>
> Which is wrong, because the Default JRE is Java 1.5, but the Project should 
> only see Java 1.3-Libraries and not both.
> -> The Default ClasspathContainer should only be added if no JRE_CONTAINER 
> (alternate JRE or a Execution Environment (>=Eclipse 3.2)) was specified. The 
> attached Patch replace the "contains"-match with a "starts-with"-match, which 
> only adds the Default ClasspathContainer if no classpathContainer is 
> configured which starts with the "JRE_CONTAINER"-Path.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to