[ 
https://issues.apache.org/jira/browse/SCM-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962780#comment-17962780
 ] 

ASF GitHub Bot commented on SCM-735:
------------------------------------

jira-importer opened a new issue, #941:
URL: https://github.com/apache/maven-scm/issues/941

   **[Gregory 
SSI-YAN-KAI](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=gssiyankai)**
 opened 
**[SCM-735](https://issues.apache.org/jira/browse/SCM-735?redirect=false)** and 
commented
   
   When a file is branched, its revision id restarts from 1.
   
   So, 2 different lines can have the same revision id even though they have 
been submitted in 2 different changelists.
   
   Since the perforce blame command is based on the revision id of each line, 
the result might be incorrect.
   
   The solution I'm proposing in the attached patch is to use changelist number 
to identify the author of a line.
   
   
   ---
   
   **Affects:** 1.8.1
   
   **Attachments:**
   - 
[blame_result_fix.patch](https://issues.apache.org/jira/secure/attachment/12718912/blame_result_fix.patch)
 (_10.24 kB_)
   - 
[scm.patch](https://issues.apache.org/jira/secure/attachment/12718522/scm.patch)
 (_8.29 kB_)
   
   3 votes, 5 watchers
   




> Blame result on branched file is incorrect
> ------------------------------------------
>
>                 Key: SCM-735
>                 URL: https://issues.apache.org/jira/browse/SCM-735
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.8.1
>            Reporter: Gregory SSI-YAN-KAI
>            Priority: Major
>         Attachments: blame_result_fix.patch, scm.patch
>
>
> When a file is branched, its revision id restarts from 1.
> So, 2 different lines can have the same revision id even though they have 
> been submitted in 2 different changelists.
> Since the perforce blame command is based on the revision id of each line, 
> the result might be incorrect.
> The solution I'm proposing in the attached patch is to use changelist number 
> to identify the author of a line.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to