jira-importer commented on issue #1116:
URL: https://github.com/apache/maven-scm/issues/1116#issuecomment-2964646694

   **[Matthieu 
Brouillard](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mcfoggy)**
 commented
   
   > The more I think about it....
   > 
   > ```
   > START..
   > START..END
   > END
   > ```
   
    
   That's a bit what I initialy wanted to do with the initial PR.
   
   But then how would you differenciate `..END` from `END` by the usage for the 
later of `CommandParameter.SCM_VERSION` instead of 
`CommandParameter.END_SCM_VERSION`?
   
   Now that I have a better overview of the code, I think it could be the best 
solution.
   
   This will end for changelog command in git world:
   
   |START_SCM_VERSION|END_SCM_VERSION|SCM_VERSION|git whatchanged 
parameters|Description|
   |:---|:---|:---|:---|:---|
   | A | B | any, not used | A..B | commits between B and A, A being an 
ancestor of B otherwise empty, without A |
   | null | B | any, not used | ..B | commits between B and HEAD, HEAD being an 
ancestor of B otherwise empty, without HEAD |
   | A | null | any, not used | A.. | commits between HEAD and A, A being an 
ancestor of HEAD otherwise empty, without A |
   | null | null | V | V | all ancestor commits starting from V |
   
   Do you agree that it is the way to go?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to