[
https://issues.apache.org/jira/browse/SCM-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17964321#comment-17964321
]
Olivier Lamy commented on SCM-168:
----------------------------------
This project has moved from Jira to GitHub Issues. This issue was migrated to
[apache/maven-scm#428|https://github.com/apache/maven-scm/issues/428].
> PerforceChangeLogConsumer should use relative paths
> ---------------------------------------------------
>
> Key: SCM-168
> URL: https://issues.apache.org/jira/browse/SCM-168
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-3
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Fix For: 1.0-beta-3
>
> Attachments: PerforceChangeLogConsumer.diff
>
>
> It seems like all scm providers are dealing with relative paths, rather than
> absolute repository paths. PerforceCheckOutCommand is definitely doing this.
> PerforceChangeLogConsumer, however, does not, which means
> ChangeSet.containsFilename always returns false because it's comparing a
> relative path to an absolute one.
> There are two changes. First, in PerforceChangeLogCommand:
> {noformat}
> PerforceChangeLogConsumer consumer = new PerforceChangeLogConsumer(
> ((PerforceScmProviderRepository) repo).getPath(), startDate, endDate );
> {noformat}
> The attached diff is for the second set of changes, which are to
> PerforceChangeLogConsumer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
