[ 
http://jira.codehaus.org/browse/MECLIPSE-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_111529
 ] 

Tony Falabella commented on MECLIPSE-143:
-----------------------------------------

I have the following configuration:
Windows XP
maven 2.0.7 (not sure if the plugin uses it's own or not so this might not be 
needed)
org.maven.ide.eclipse_0.0.11.20070916-2300
org.maven.ide.eclipse.feature_0.0.11.20070916-2300
eclipse 3.3

As of 2007-10-26, this still appears to be an issue. It is as the other bug 
http://jira.codehaus.org/browse/MECLIPSE-143 describes. If you have both 
"Download Artifact Sources" and "Download Artifact JavaDocs" options checked, 
if sources are found for a library it doesn't even look for JavaDocs.

As a test I created a repository that has both the xxx-javadoc.jar and 
xxx-sources.jar. I've turned DEBUG logging on. If I have both "Download 
Artifact Sources" and "Download Artifact JavaDocs" options checked I never see 
anything in the log for it attempting to even look for the xxx-javadoc.jar . 
Thus no xxx-javadoc.jar ends up in the localrepos. It does properly find the 
xxx-sources.jar and that then appears in the localrepos. If I remove the 
dependency, clear out the localrepos, and only check the "Download Artifact 
JavaDocs" option and try again, I see the following in the log:
{noformat}
10/26/07 9:06:28 AM EDT: [DEBUG] Trying repository tonylocal2
10/26/07 9:06:28 AM EDT: [DEBUG] SHA1 not found, trying MD5 File: C:\Documents 
and 
Settings\af25830\.m2\futures-source-repository2\org\acegisecurity\acegi-security\1.0.3\acegi-security-1.0.3-javadoc.jar.sha1
 does not exist
10/26/07 9:06:28 AM EDT: [WARN] *** CHECKSUM FAILED - Error retrieving checksum 
file for 
org/acegisecurity/acegi-security/1.0.3/acegi-security-1.0.3-javadoc.jar - 
IGNORING
10/26/07 9:06:28 AM EDT: [DEBUG]   Artifact resolved
10/26/07 9:06:28 AM EDT: Scanned javadoc C:/Documents and 
Settings/af25830/.m2/localrepository/org/acegisecurity/acegi-security/1.0.3/acegi-security-1.0.3-javadoc.jar
 0.0
{noformat}
In this case it does properly find the xxx-javadocs.jar and they then appear in 
the localrepos and are properly associated as javadocs with the jar in Eclipse.

I agree though, it should not be an "either-or" in regards to downloading 
source or javadocs. 

> eclipse:eclipse adds sourcepath or javadocpath to .classpath but not both
> -------------------------------------------------------------------------
>
>                 Key: MECLIPSE-143
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-143
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>         Environment: Windows XP
> Maven 2.0.4
> maven-eclipse-plugin 2.2
>            Reporter: Edin Pezerovic
>            Assignee: Kenney Westerhof
>
> issuing a mvn eclipse:eclipse generates the .classpath file with either 
> <attributes> tag within classpathentry or a sourcepath-attribute for the 
> classpathentry, but never both. 
> I think, the "else" in the code below is the bug and should be removed. (File 
> EclipseClasspathWriter, Method addDependency)
> ......
>         if ( sourcepath != null )
>         {
>             writer.addAttribute( ATTR_SOURCEPATH, sourcepath );
>         }
>         ELSE if ( javadocpath != null )
>         {
>             writer.startElement( "attributes" ); //$NON-NLS-1$
>             writer.startElement( "attribute" ); //$NON-NLS-1$
>             writer.addAttribute( "value", "jar:file:/" + javadocpath + "!/" 
> ); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
>             writer.addAttribute( "name", "javadoc_location" ); //$NON-NLS-1$ 
> //$NON-NLS-2$
>             writer.endElement();
>             writer.endElement();
>         }
> .....

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to