[ 
http://jira.codehaus.org/browse/MECLIPSE-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_111414
 ] 

Pascal Thivent commented on MECLIPSE-333:
-----------------------------------------

I have downloaded the tar with all new files and applied the patch on a clean 
maven-eclipse-plugin checkout. 

I ran mvn install and got one error in the testJeeSimple() method of the 
EclipsePluginTest  because of a missing dependency. I did a mvn install on the 
j2ee-simple bundled project as workaround to make the build pass. I can't 
remember out of my head which artifact was missing but I finally succeeded to 
build the plugin without skipping the tests. The strange part is that I just 
tried to reproduce this (after a mvn clean and removing everything related to 
the plugin from my local repository) but... unsuccessfully. When I check 
target\test-classes\m2repo\root\project, I see all required artifacts this time 
so they must have been build correctly. This try has been done under WindowsXP 
when the first attempt was under Linux. I'll try again at home. 

Another thing : I'm using a JDK6 and noticed I had to add some 
maven-compiler-plugin configuration in my pom.xml to get the correct Java Facet 
in eclipse. Without this, the generated Java Facet was 1.4. This happens only 
when I had configuration for WTP2.0 support. This is non blocking but I just 
wanted to let you know.

Nice work anyway.

> WTP-2.0 support with howto apt, refactoring and  contextroot handling
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-333
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-333
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: multiproject, WTP support
>    Affects Versions: 2.5
>            Reporter: Richard van Nieuwenhoven
>            Assignee: Brian Fox
>         Attachments: maven-eclipse-plugin_only_new.tar.gz, 
> wtp-2.0-and-more-2.5-SNAPSHOT.patch
>
>
> This patch contains:
> - WTP.2.0 support for ear and war's (includes MECLIPSE-264)
> - context root handling very much improved
>       (war takes configuration from the ear, if available)
> - refactoring (constant usage, foreign plug-in access centralized)
> - a detailed description how we use maven-2 with WTP in multi module projects
> - testing code included
> the patch is attached, together with a tar with all the new files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to