jira-importer commented on issue #156: URL: https://github.com/apache/maven-jar-plugin/issues/156#issuecomment-2956674111
**[Nathan Revo](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=revoman)** commented [Michael Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)I will look into creating a patch. What maven version were you referring to in your comment? Also, it felt like my custom plugin would turn into a messy patch as I was calling the "javac" command directly and parsing the output. Here are some questions I have that should be addressed before a meaningful patch can be created: * How are these options handled for for compiling code and/or making archives (jar files). What is the precedence? * - runtime jdk. assuming it is a JDK and not just a JRE use javac/jar binaries from here? * - toolchains.xml, is it present, is it configured properly, use javac/jar binaries from here? * - compiler executable, do I use the value from the maven compiler plugin, do I provide one in the archiver plugin? * - java.home environment variable, is this where javac or jar are executed from? * which plugin will this be added to? archiver, compiler, jar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
