jira-importer commented on issue #268:
URL: 
https://github.com/apache/maven-build-cache-extension/issues/268#issuecomment-2955434136

   
**[Xaver](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=JIRAUSER303756)**
 commented
   
   Hi there,
   V1.0.1 works awesome (we use it in a large multi module project and reduced 
computation costs of CI/CD by ~80%)! Thanks a lot for it.
   
   I think that the merge of 
[PR#117](https://github.com/apache/maven-build-cache-extension/pull/117) / 
MBUILDCACHE-76 was a mistake.
   
   Please look at the [description of the 
extension](https://maven.apache.org/extensions/maven-build-cache-extension/):
   
   ```
   Version normalization supports project *version agnostic caches*
   ```
   
   Have a look at the code:
   
https://github.com/apache/maven-build-cache-extension/blob/maven-build-cache-extension-1.1.0/src/main/java/org/apache/maven/buildcache/DefaultNormalizedModelProvider.java#L81-L82
   The version is explicitly removed to achieve the version agnostic cache
   
   ```java
   // does not make sense to add project version to calculate hash
   resultModel.setVersion(NORMALIZED_VERSION);
   ```
   
   Other modern build tools I know (e.g. gradle, nx.dev) use version agnostic 
caches. I really missed this feature a lot.
   
   Please don't close this issue. It's important for many use cases that the 
version is optional for checksum calculation.
   
   Thank you from a happy 1.0.1 user.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to