Pankraz76 commented on code in PR #2434: URL: https://github.com/apache/maven/pull/2434#discussion_r2128631088
########## impl/maven-core/src/test/java/org/apache/maven/model/WrapperPropertiesTest.java: ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.model; + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.StringReader; +import java.io.StringWriter; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import java.util.Set; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.function.Consumer; +import java.util.function.Supplier; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +class WrapperPropertiesTest { + private Map<String, String> backingStore; + private AtomicBoolean getterCalled; + private AtomicBoolean setterCalled; + private WrapperProperties wrapper; + + @BeforeEach + void setUp() { + backingStore = new HashMap<>(); + getterCalled = new AtomicBoolean(false); + setterCalled = new AtomicBoolean(false); + + Supplier<Map<String, String>> getter = () -> { + getterCalled.set(true); + return new HashMap<>(backingStore); + }; + + Consumer<Properties> setter = props -> { + setterCalled.set(true); + backingStore.clear(); + props.forEach((k, v) -> backingStore.put(k.toString(), v.toString())); + }; + + wrapper = new WrapperProperties(getter, setter); + } + + @Test + void testInitialization() { + wrapper.getProperty("any"); + assertTrue(getterCalled.get()); + } + + @Test + void testBasicOperations() { + // Test set and get + wrapper.setProperty("key1", "value1"); + assertEquals("value1", wrapper.getProperty("key1")); + assertEquals("value1", backingStore.get("key1")); + assertTrue(setterCalled.get(), "Setter should be called after modification"); + + // Test remove + wrapper.remove("key1"); + assertNull(wrapper.getProperty("key1")); + assertFalse(backingStore.containsKey("key1")); + + // Test contains + wrapper.setProperty("key2", "value2"); + assertTrue(wrapper.containsKey("key2")); + assertTrue(wrapper.containsValue("value2")); + } + + @Test + void testOrderPreservation() { + wrapper.setProperty("a", "1"); + wrapper.setProperty("b", "2"); + wrapper.setProperty("c", "3"); + + // Check iteration order matches insertion order + Set<Object> keys = wrapper.keySet(); + Object[] keyArray = keys.toArray(); + assertEquals("a", keyArray[0]); + assertEquals("b", keyArray[1]); + assertEquals("c", keyArray[2]); + + // Modify existing value and check order remains + wrapper.setProperty("b", "22"); + keyArray = wrapper.keySet().toArray(); + assertEquals("a", keyArray[0]); + assertEquals("b", keyArray[1]); + assertEquals("c", keyArray[2]); + } + + @Test + @Disabled("should not throw NPE but does...") Review Comment: could merge and check afterward. NPE is 2 times now, worth to check or remove test, as its AI created, which i only check if not working. My bare tactic is to cover first 100%, then its time to invest on (random) details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
