Pankraz76 commented on code in PR #2428:
URL: https://github.com/apache/maven/pull/2428#discussion_r2125838674
##########
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java:
##########
@@ -176,17 +175,14 @@ public <Q> Supplier<Q> getCompiledBinding(Dependency<Q>
dep) {
private <Q> Supplier<Q> getBeanSupplier(Dependency<Q> dep, Key<Q> key)
{
List<Binding<?>> list = new ArrayList<>();
- // Add DI bindings
list.addAll(getBindings().getOrDefault(key, Set.of()));
- // Add Plexus bindings
for (var bean : locator.get().locate(toGuiceKey(key))) {
if (isPlexusBean(bean)) {
list.add(new
BindingToBeanEntry<>(key).toBeanEntry(bean).prioritize(bean.getRank()));
}
}
if (!list.isEmpty()) {
- list.sort(getBindingComparator());
- //noinspection unchecked
+ list.sort(null); // Uses Binding's compareTo
Review Comment:
move to root
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
