Pankraz76 commented on code in PR #2423:
URL: https://github.com/apache/maven/pull/2423#discussion_r2120208265


##########
compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t02/ProjectInheritanceTest.java:
##########
@@ -64,7 +65,7 @@ class ProjectInheritanceTest extends 
AbstractProjectInheritanceTestCase {
     // ----------------------------------------------------------------------
 
     @Test
-    @DisabledOnOs(OS.WINDOWS) // need to investigate why it fails on windows
+    @DisabledOnOs(WINDOWS)

Review Comment:
   ```suggestion
       @DisabledOnOs(WINDOWS) // todo need to investigate why it fails on 
windows
   ```
   imho its clear to revisit the ignores. If its important then would highlight 
it with `todo` or `fixme` to make clear statement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to