elharo commented on code in PR #2395:
URL: https://github.com/apache/maven/pull/2395#discussion_r2117680125
##########
compat/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java:
##########
@@ -132,18 +132,10 @@ public boolean checkOutOfDate(Date lastModified) {
@Override
public String toString() {
- StringBuilder buffer = new StringBuilder(64);
- buffer.append("{enabled=");
- buffer.append(enabled);
- buffer.append(", checksums=");
- buffer.append(checksumPolicy);
- buffer.append(", updates=");
- buffer.append(updatePolicy);
- buffer.append('}');
- return buffer.toString();
+ return "{enabled=" + enabled + ", checksums=" + checksumPolicy + ",
updates=" + updatePolicy + '}';
Review Comment:
If the PRs aren't more focused, they can't be reviewed quickly
##########
compat/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java:
##########
@@ -132,18 +132,10 @@ public boolean checkOutOfDate(Date lastModified) {
@Override
public String toString() {
- StringBuilder buffer = new StringBuilder(64);
- buffer.append("{enabled=");
- buffer.append(enabled);
- buffer.append(", checksums=");
- buffer.append(checksumPolicy);
- buffer.append(", updates=");
- buffer.append(updatePolicy);
- buffer.append('}');
- return buffer.toString();
+ return "{enabled=" + enabled + ", checksums=" + checksumPolicy + ",
updates=" + updatePolicy + '}';
}
- public void merge(ArtifactRepositoryPolicy policy) {
Review Comment:
not in this PR, maybe not at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
