ppkarwasz commented on issue #165: URL: https://github.com/apache/maven-gh-actions-shared/issues/165#issuecomment-2922796053
Unless I'm mistaken, an ICLA is only required when a contributor is being granted commit access, or when submitting **substantial** contributions through less traceable channels such as email—where verifying the provenance of the code is more difficult. In the case of PRs, especially those that include tests, it's quite common for even small contributions to exceed 20 lines due to boilerplate and testing requirements. As such, using line count as a trigger for mentioning the ICLA may not be meaningful. Instead of referencing ICLAs by default, it might be better to leave it to the discretion of the reviewing committer. If a PR is deemed substantial enough to warrant an ICLA, the committer can always request it during the review process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
