Pankraz76 commented on code in PR #2375:
URL: https://github.com/apache/maven/pull/2375#discussion_r2111240837
##########
impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java:
##########
@@ -77,8 +107,15 @@ void testAptConsistency() throws Exception {
ArtifactHandler handler =
container.lookup(ArtifactHandlerManager.class).getArtifactHandler(type);
assertEquals(handler.getExtension(), extension, type + "
extension");
- // Packaging/Directory is Maven1 remnant!!!
- // assertEquals(handler.getPackaging(), packaging, type + "
packaging");
+ assertThat(PACKAGING_TYPES).contains(handler.getPackaging(),
packaging);
+ if (handler.getPackaging().equals("test-jar")) {
+ assertEquals("jar", packaging);
+
+ } else if (handler.getPackaging().equals("ejb-client")) {
+ assertEquals("ejb", packaging);
Review Comment:
both look like but to me. maven-archetype",
"maven-plugin", "java-source" are all equal so why not these two
? So its not a hyphen thing in general, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
