Ndacyayisenga-droid commented on code in PR #213:
URL:
https://github.com/apache/maven-build-cache-extension/pull/213#discussion_r2095413371
##########
src/main/java/org/apache/maven/buildcache/hash/HashFactory.java:
##########
@@ -28,14 +28,14 @@
* HashFactory
*/
public enum HashFactory {
- SHA1(new SHA("SHA-1")),
- SHA256(new SHA("SHA-256")),
- SHA384(new SHA("SHA-384")),
- SHA512(new SHA("SHA-512")),
- XX(new Zah("XX", LongHashFunction.xx(), Zah.MemoryPolicy.Standard)),
- XXMM(new Zah("XXMM", LongHashFunction.xx(),
Zah.MemoryPolicy.MemoryMappedBuffers)),
- METRO(new Zah("METRO", LongHashFunction.metro(),
Zah.MemoryPolicy.Standard)),
- METRO_MM(new Zah("METRO+MM", LongHashFunction.metro(),
Zah.MemoryPolicy.MemoryMappedBuffers));
+ sha1(new SHA("SHA-1")),
Review Comment:
> this should not be affected by new checkstyle rules
@slawekjaranowski @olamy This what I get for the build
```
[INFO] --- checkstyle:3.6.0:check (checkstyle-check) @
maven-build-cache-extension ---
[INFO] There are 35 errors reported by Checkstyle 9.3 with
config/maven_checks_nocodestyle.xml ruleset.
[ERROR] src/test/java/org/apache/maven/buildcache/hash/PerfTest.java:[76,19]
(naming) MethodName: Name 'SHA1' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR] src/test/java/org/apache/maven/buildcache/hash/PerfTest.java:[81,19]
(naming) MethodName: Name 'SHA256' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR] src/test/java/org/apache/maven/buildcache/hash/PerfTest.java:[86,19]
(naming) MethodName: Name 'XX' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR] src/test/java/org/apache/maven/buildcache/hash/PerfTest.java:[91,19]
(naming) MethodName: Name 'XXMM' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR] src/test/java/org/apache/maven/buildcache/hash/PerfTest.java:[96,19]
(naming) MethodName: Name 'METRO' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR]
src/test/java/org/apache/maven/buildcache/hash/PerfTest.java:[101,19] (naming)
MethodName: Name 'METRO_MM' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR]
src/test/java/org/apache/maven/buildcache/its/RemoteCacheDavTest.java:[287,5]
(sizes) MethodLength: Method ls length is 165 lines (max allowed is 150).
[ERROR]
src/test/java/org/apache/maven/buildcache/its/RemoteCacheDavTest.java:[294,13]
(modifier) RedundantModifier: Redundant 'public' modifier.
[ERROR]
src/test/java/org/apache/maven/buildcache/its/IncrementalRestoreTest.java:[99,5]
(sizes) MethodLength: Method simple length is 231 lines (max allowed is 150).
[ERROR]
src/test/java/org/apache/maven/buildcache/its/Issue74Test.java:[44,33] (naming)
ConstantName: Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR]
src/test/java/org/apache/maven/buildcache/its/Issue76Test.java:[32,10] (naming)
MethodName: Name 'simple_build_change_version_build_install_again' must match
pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR]
src/test/java/org/apache/maven/buildcache/its/CoreExtensionTest.java:[46,10]
(naming) MethodName: Name 'simple_build_change_version_reuse_build_cache' must
match pattern '^[a-z][a-zA-Z0-9]*$'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[48,9]
(coding) UnusedLocalVariable: Unused local variable 'doc'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[52,15]
(coding) UnusedLocalVariable: Unused local variable 'cache'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[64,9]
(coding) UnusedLocalVariable: Unused local variable 'doc'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[68,15]
(coding) UnusedLocalVariable: Unused local variable 'cacheReport'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[80,9]
(coding) UnusedLocalVariable: Unused local variable 'doc'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[84,15]
(coding) UnusedLocalVariable: Unused local variable 'build'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[96,9]
(coding) UnusedLocalVariable: Unused local variable 'doc'.
[ERROR]
src/test/java/org/apache/maven/buildcache/xml/XmlServiceTest.java:[100,15]
(coding) UnusedLocalVariable: Unused local variable 'buildDiff'.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[403,21]
(design) VisibilityModifier: Variable 'txtFileRootFolder' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[404,21]
(design) VisibilityModifier: Variable 'javaFileRootFolder' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[405,21]
(design) VisibilityModifier: Variable 'jsonFileRootFolder' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[406,21]
(design) VisibilityModifier: Variable 'folder1' must be private and have
accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[407,21]
(design) VisibilityModifier: Variable 'txtFileFolder1' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[408,21]
(design) VisibilityModifier: Variable 'javaFileFolder1' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[409,21]
(design) VisibilityModifier: Variable 'jsonFileFolder1' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[410,21]
(design) VisibilityModifier: Variable 'subFolder1' must be private and have
accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[411,21]
(design) VisibilityModifier: Variable 'txtFileSubFolder1' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[412,21]
(design) VisibilityModifier: Variable 'javaFileSubFolder1' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[413,21]
(design) VisibilityModifier: Variable 'jsonFileSubFolder1' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[414,21]
(design) VisibilityModifier: Variable 'folder2' must be private and have
accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[415,21]
(design) VisibilityModifier: Variable 'txtFileFolder2' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[416,21]
(design) VisibilityModifier: Variable 'javaFileFolder2' must be private and
have accessor methods.
[ERROR]
src/test/java/org/apache/maven/buildcache/checksum/InputExclusionTest.java:[417,21]
(design) VisibilityModifier: Variable 'jsonFileFolder2' must be private and
have accessor methods.
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 11.737 s
[INFO] Finished at: 2025-05-15T09:53:02+03:00
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
