Ndacyayisenga-droid commented on PR #213: URL: https://github.com/apache/maven-build-cache-extension/pull/213#issuecomment-2890134520
> There is #200 > > Did you build / test your PR? I updated the maven-parent to version 44 in this PR, which seems to have introduced stricter Checkstyle rules that were not enforced previously. This caused a large number of Checkstyle violations to surface when running mvn clean install, making the build fail. To ensure a clean build, I addressed the following kinds of issues raised by Checkstyle: **1. Method name formatting:** Methods like `SHA1`, `SHA256`, `XX`, etc., were flagged for not following the required lowerCamelCase convention. **2. Method length:** Some test methods (e.g., `ls`, `simple`) exceeded the maximum allowed line count of 150. **3. Redundant modifiers:** A few methods had redundant public modifiers within test classes. **4. Constant and variable naming:** Identifiers like `logger` were flagged for not using uppercase with underscores for constants. **5. Unused local variables:** Several tests in `XmlServiceTest` and others had unused variables that were flagged. **6. Visibility modifiers:** Test class fields were flagged for not being private or not having accessor methods. These changes were necessary just to get a successful build with the updated parent version. cc @olamy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
