gnodet commented on code in PR #2274:
URL: https://github.com/apache/maven/pull/2274#discussion_r2087393505


##########
impl/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultTypeRegistry.java:
##########
@@ -55,11 +53,8 @@ public class DefaultTypeRegistry extends AbstractEventSpy 
implements TypeRegistr
     private final LegacyArtifactHandlerManager manager;
 
     @Inject
-    public DefaultTypeRegistry(
-            List<TypeProvider> providers, LanguageRegistry languageRegistry, 
LegacyArtifactHandlerManager manager) {
-        this.types = requireNonNull(providers, "providers cannot be 
null").stream()
-                .flatMap(p -> p.provides().stream())
-                .collect(Collectors.toMap(Type::id, identity()));
+    public DefaultTypeRegistry(Lookup lookup, LanguageRegistry 
languageRegistry, LegacyArtifactHandlerManager manager) {
+        this.lookup = lookup;

Review Comment:
   AFAIK, nullable must be opt-in for injection, so no annotation here means 
the dependencies are required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to