[
https://issues.apache.org/jira/browse/MDEP-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946590#comment-17946590
]
ASF GitHub Bot commented on MDEP-976:
-------------------------------------
Ndacyayisenga-droid opened a new pull request, #523:
URL: https://github.com/apache/maven-dependency-plugin/pull/523
Fixes https://issues.apache.org/jira/browse/MDEP-976
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> artifactId is not guaranteed to be globally unique
> --------------------------------------------------
>
> Key: MDEP-976
> URL: https://issues.apache.org/jira/browse/MDEP-976
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: copy-dependencies
> Affects Versions: 3.8.1
> Reporter: Gili
> Priority: Major
>
> The copy-dependencies Mojo incorrectly assumes that a dependency's artifactId
> is globally unique. If a project depends on two different groupIds that
> happen to have the same artifactId then one dependency will overwrite the
> other.
> Consider adding ${groupId} to the default output filename and/or add an
> option for doing so in case users wish to retain backwards compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
