Re: [PR] [MNG-8712] dependency version is a requirement, not effective [maven]

[via GitHub]

elharo commented on code in PR #2279:
URL: https://github.com/apache/maven/pull/2279#discussion_r2066248063


##########
maven-model/src/main/mdo/maven.mdo:
##########
@@ -1087,8 +1087,10 @@
           <version>3.0.0+</version>
           <description>
             <![CDATA[
-            The version of the dependency, e.g. <code>3.2.1</code>. In Maven 
2, this can also be
-            specified as a range of versions.
+            The version requirement of the dependency, e.g. <code>3.2.1</code> 
for soft version requirement: the effective version will be resolved based on 
the usage context.

Review Comment:
   I can follow this, but you really need to be pretty deep in Maven to grok 
terms like "soft version" and "effective version". Maybe something like 
   
   The version requirement of the dependency, e.g. <code>3.2.1</code>. The 
actual version added to the classpath at runtime and compile time may change 
depending on other dependencies in the tree.



##########
maven-model/src/main/mdo/maven.mdo:
##########
@@ -1087,8 +1087,10 @@
           <version>3.0.0+</version>
           <description>
             <![CDATA[
-            The version of the dependency, e.g. <code>3.2.1</code>. In Maven 
2, this can also be
-            specified as a range of versions.
+            The version requirement of the dependency, e.g. <code>3.2.1</code> 
for soft version requirement: the effective version will be resolved based on 
the usage context.
+            Version requirement can also be specified as a range of versions, 
e.g. <code>[3.2.0,)</code>: notice this is discouraged, as it may break 
<i>predictability</i> of resolved version.

Review Comment:
   ": notice this is discouraged, as it may break" -->". This is discouraged as 
it breaks"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org