[
https://issues.apache.org/jira/browse/MBUILDCACHE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943177#comment-17943177
]
ASF GitHub Bot commented on MBUILDCACHE-111:
--------------------------------------------
sebtiem opened a new pull request, #201:
URL: https://github.com/apache/maven-build-cache-extension/pull/201
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [MBUILDCACHE JIRA
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Documentation uses build-cache-config 1.0.0 XML schema instead of 1.2.0 schema
> ------------------------------------------------------------------------------
>
> Key: MBUILDCACHE-111
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-111
> Project: Maven Build Cache Extension
> Issue Type: Bug
> Reporter: Maurice Zeijen
> Priority: Major
>
> Several places in the documentation, like the
> [Howto|https://maven.apache.org/extensions/maven-build-cache-extension/how-to.html]
> page and the
> [maven-build-cache-config.xml|https://maven.apache.org/extensions/maven-build-cache-extension/build-cache-config.html]
> page, refer to the 1.0.0 version of the build-cache-config XML schema
> instead of the newer 1.2.0 version.
> Because I was not aware of there being a newer schema, we where using the
> 1.0.0 schema in combination with the 1.2.0 version of the build cache.
> Although this works, it does cause validation issues in the IDE when new
> features are used like the `glob` attribute on the `exclude` element, which
> causes confusion.
> So instead of:
>
> {code:java}
> <cache xmlns="http://maven.apache.org/BUILD-CACHE-CONFIG/1.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/BUILD-CACHE-CONFIG/1.0.0
> https://maven.apache.org/xsd/build-cache-config-1.0.0.xsd";> {code}
> this should be used in the documentation:
>
> {code:java}
> <cache xmlns="http://maven.apache.org/BUILD-CACHE-CONFIG/1.2.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/BUILD-CACHE-CONFIG/1.2.0
> https://maven.apache.org/xsd/build-cache-config-1.2.0.xsd";> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
