talios commented on code in PR #1209: URL: https://github.com/apache/maven/pull/1209#discussion_r2032665677
########## its/core-it-suite/src/test/resources/mng-5102-mixins/gav/project/pom.xml: ########## @@ -0,0 +1,60 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.1.0"; root="true"> + <groupId>org.apache.maven.its.mng5102</groupId> + <artifactId>gav</artifactId> + <version>0.1</version> + <packaging>pom</packaging> + + <name>Maven Integration Test :: MNG-5102</name> + <description>Mixins tests.</description> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.its.plugins</groupId> + <artifactId>maven-it-plugin-expression</artifactId> + <version>2.1-SNAPSHOT</version> + <executions> + <execution> + <goals> + <goal>eval</goal> + </goals> + <phase>validate</phase> + <configuration> + <outputFile>target/model.properties</outputFile> + <expressions> + <expression>project/properties</expression> + </expressions> + </configuration> + </execution> + </executions> + </plugin> + </plugins> + </build> + + <mixins> + <mixin> + <groupId>org.apache.maven.its.mng5102</groupId> + <artifactId>mixin-2</artifactId> Review Comment: Finally got around to testing this (it's been a hectic fortnight). From a fresh `archetype:generated` project, and updating the `model` version and XML preamble, adding the following maven tile "mixin": ```xml <mixins> <mixin> <groupId>com.smxemail.tiles</groupId> <artifactId>com.smxemail.tiles.enforcements</artifactId> <version>4.0.176</version> <extension>xml</extension> </mixin> </mixins> ``` Everything seemed to work as expected! Compared to the tiles config: ```xml <plugin> <groupId>io.repaint.maven</groupId> <artifactId>tiles-maven-plugin</artifactId> <version>2.40</version> <extensions>true</extensions> <configuration> <tiles> <tile>com.smxemail.tiles:com.smxemail.tiles.enforcements:[4.0.176]</tile> </tiles> </configuration> </plugin> ``` I long for the day when we can have some more concise GAV specifications in Maven, but this is looking good as a transition. The tile does transclude another tile, which obviously doesn't work here. I will craft one with its own `<mixin>` element and do some further testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
