gnodet commented on PR #243:
URL:
https://github.com/apache/maven-clean-plugin/pull/243#issuecomment-2777690035
> > > > I think that would make sense. The point is that the resource plugin
can also be configured from the plugin, so with Path or String, but definitely
not PathMatcher.
> > >
> > >
> > > Okay, will prepare a pull request maybe tonight.
> >
> >
> > Actually, maybe the problem was just in the implementation of the
`PathMatcher` provided by Maven when building the `SourceRoot`, as the
implementation in Maven does not deal with glob syntax slight difference. I did
not investigate too much and went back to using strings when working on the
maven-filtering / maven-resource-plugin. But in order to make sure everything
use a coherent syntax, it may make sense that Maven provides the `PathMatcher`
for all plugins to leverage. In which case, moving the `Selector` class from
this pattern inside maven-core would make sense, and have `SourceRoot` return a
single `PathMatcher` instead of `getIncludes()` and `getExcludes()`...
>
> Forget the above. Even just for the sake of being able to obtain
`Resource` objects from the project to support Maven 3 plugins, we'll need the
includes and excludes as a collection of strings. So yes, we definitely need to
revert {{SourceRoot} to using Strings.
Created https://github.com/apache/maven/pull/2232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
