gnodet commented on PR #243: URL: https://github.com/apache/maven-clean-plugin/pull/243#issuecomment-2776936980
> > I think that would make sense. The point is that the resource plugin can also be configured from the plugin, so with Path or String, but definitely not PathMatcher. > > Okay, will prepare a pull request maybe tonight. Actually, maybe the problem was just in the implementation of the `PathMatcher` provided by Maven when building the `SourceRoot`, as the implementation in Maven does not deal with glob syntax slight difference. I did not investigate too much and went back to using strings when working on the maven-filtering / maven-resource-plugin. But in order to make sure everything use a coherent syntax, it may make sense that Maven provides the `PathMatcher` for all plugins to leverage. In which case, moving the `Selector` class from this pattern inside maven-core would make sense, and have `SourceRoot` return a single `PathMatcher` instead of `getIncludes()` and `getExcludes()`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
