cstamas commented on code in PR #2226: URL: https://github.com/apache/maven/pull/2226#discussion_r2026882321
########## impl/maven-impl/pom.xml: ########## @@ -112,6 +112,22 @@ under the License. <groupId>org.apache.maven.resolver</groupId> <artifactId>maven-resolver-impl</artifactId> </dependency> + <dependency> Review Comment: am unsure are these deps really needed here, maybe only for test? As if you make them required, you make apache transport or basic connector "mandatory". I'd rather put back these into test scope of maven-impl and let "mima-like use case" user pick deps he needs instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org