[ 
http://jira.codehaus.org/browse/MECLIPSE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_108217
 ] 

Michael Schnake commented on MECLIPSE-264:
------------------------------------------

Sorry that I did not spend any attention to this bug for some time now (been 
busy in another project).

Cris, thank you for that patch. I checked out and applied against the exact 
revision (572678) mentioned in the patch file, compiled, installed and updated 
my project to using the just locally installed maven-eclipse-plugin 
"2.5-SNAPSHOT" and setting WTP-Version to "2.0". Then a "mvn eclipse:clean" and 
"eclipse:eclipse" from the modules root, and ... drumroll ...

The generated eclipse projects work "out of the box" now (with the patch, and 
after adjusting AspectJ Path (see MECLIPSE-270)). The generated files look 
correct, and a quick cross-check via cleaning and rebuilding everything inside 
eclipse (code, tomcat modules, tomcat workdir, tomcat everything ;-) produces a 
working application.

So, thumbs up from me to merge patch 264. And if general attributes could be 
addressed, too (like you already denoted in MECLIPSE-270) my current WTP 2.0 
issues were solved completely.

GOOD WORK! 

> Support for WTP2.0
> ------------------
>
>                 Key: MECLIPSE-264
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-264
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: WTP support
>            Reporter: Geir Pettersen
>         Attachments: maven-264.patch
>
>
> As far as I can see this plugin only supports WTP version 1.0 and 1.5. while 
> WTP 2.0 is already released in milestone 6

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to