gnodet commented on code in PR #671: URL: https://github.com/apache/maven-resolver/pull/671#discussion_r1998884156
########## maven-resolver-spi/src/main/java/org/eclipse/aether/spi/validator/Validator.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.eclipse.aether.spi.validator; + +import org.eclipse.aether.artifact.Artifact; +import org.eclipse.aether.graph.Dependency; +import org.eclipse.aether.metadata.Metadata; +import org.eclipse.aether.repository.LocalRepository; +import org.eclipse.aether.repository.RemoteRepository; + +/** + * A repository system main input validator; this validator is used in repository system "main entry methods". + * + * @since 2.0.8 + */ +public interface Validator { + /** + * Validates artifact. + * + * @param artifact The artifact to validate, never {@code null}. + * @throws IllegalArgumentException if artifact is invalid. + */ + default void isValidArtifact(Artifact artifact) throws IllegalArgumentException {} + + /** + * Validates metadata. + * + * @param metadata The metadata to validate, never {@code null}. + * @throws IllegalArgumentException if artifact is invalid. + */ + default void isValidMetadata(Metadata metadata) throws IllegalArgumentException {} + ; Review Comment: Remove the `;` ########## maven-resolver-spi/src/main/java/org/eclipse/aether/spi/validator/Validator.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.eclipse.aether.spi.validator; + +import org.eclipse.aether.artifact.Artifact; +import org.eclipse.aether.graph.Dependency; +import org.eclipse.aether.metadata.Metadata; +import org.eclipse.aether.repository.LocalRepository; +import org.eclipse.aether.repository.RemoteRepository; + +/** + * A repository system main input validator; this validator is used in repository system "main entry methods". + * + * @since 2.0.8 + */ +public interface Validator { + /** + * Validates artifact. + * + * @param artifact The artifact to validate, never {@code null}. + * @throws IllegalArgumentException if artifact is invalid. + */ + default void isValidArtifact(Artifact artifact) throws IllegalArgumentException {} + + /** + * Validates metadata. + * + * @param metadata The metadata to validate, never {@code null}. + * @throws IllegalArgumentException if artifact is invalid. + */ + default void isValidMetadata(Metadata metadata) throws IllegalArgumentException {} + ; + + /** + * Validates dependency. + * + * @param dependency The dependency to validate, never {@code null}. + * @throws IllegalArgumentException if dependency is invalid. + */ + default void isValidDependency(Dependency dependency) throws IllegalArgumentException {} + + /** + * Validates local repository. + * + * @param localRepository The local repository to validate, never {@code null}. + * @throws IllegalArgumentException if local repository is invalid. + */ + default void isValidLocalRepository(LocalRepository localRepository) throws IllegalArgumentException {} + ; Review Comment: That one too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
