cstamas commented on code in PR #2147: URL: https://github.com/apache/maven/pull/2147#discussion_r1983709737
########## api/maven-api-cli/src/main/java/org/apache/maven/api/cli/CoreExtensions.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api.cli; + +import java.util.List; + +import org.apache.maven.api.Constants; +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.cli.extensions.CoreExtension; + +import static java.util.Objects.requireNonNull; + +/** + * Represents the list of core extensions configured at one source. The list is validated (are GA unique), but no + * other logic than that is applied. + * + * @since 4.0.0 + * @param source The source of core extensions, is never {@code null}. + * @param coreExtensions The configured core extensions, is never {@code null}. Contents of list is guaranteed to be unique by GA. + */ +@Experimental +public record CoreExtensions(Source source, List<CoreExtension> coreExtensions) { + /** + * Represents the source of configured core extensions and their precedence. + */ + public enum Source { Review Comment: I wanted two pieces of informations: * "source" as "label" (used when in DEBUG am fully logging which came from where) * precedence But am fine, we can say that `InvokerRequest` contains sources in "precedence order"? Would need some slight changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
