Re: [PR] [MNG-8588] Add activated profiles to Project interface [maven]

[via GitHub]

gnodet commented on PR #2119:
URL: https://github.com/apache/maven/pull/2119#issuecomment-2680897510

   > @gnodet I think it is time for weekend for me. I was adding missing tests 
to the `getActiveProfiles()` and ended up forgetting to add the tests for the 
`getInjectedProfileIds()` 🙈. I'll add those in the next commit.
   > 
   > Thinking out loud / alternative:
   > 
   > While testing though, it might be better to replace the 
`getInjectedProfileIds()` with `getActiveProfiles()` in the `DefaultProject` 
and utilise the `Locations`. We could reference the actual file used for the 
external profiles instead of hardcoding "external". We could also reference the 
line number of the active profile as well.
   > 
   > <img alt="image" width="796" 
src="https://private-user-images.githubusercontent.com/27761321/415792002-27890793-d235-4799-a0a8-c17d58598c69.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDA0MzYyNzgsIm5iZiI6MTc0MDQzNTk3OCwicGF0aCI6Ii8yNzc2MTMyMS80MTU3OTIwMDItMjc4OTA3OTMtZDIzNS00Nzk5LWEwYTgtYzE3ZDU4NTk4YzY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjI0VDIyMjYxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE1OTJmYzIzODMzMjA2NGMyOTI2MzllMWYyNmQ0NjNmYTM4MDAzMTc3OTEzNzgwMTlhNTU2ZjljNzMyY2JlZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OxqzP-LwPkXqXoS-m_MC48_89ImDDT6jYtGIVu3cmVs";>
   > **maven-help-plugin 3.5.1** <img alt="image" width="739" 
src="https://private-user-images.githubusercontent.com/27761321/415792353-7cbcc87c-b497-416c-8801-992618375e2a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDA0MzYyNzgsIm5iZiI6MTc0MDQzNTk3OCwicGF0aCI6Ii8yNzc2MTMyMS80MTU3OTIzNTMtN2NiY2M4N2MtYjQ5Ny00MTZjLTg4MDEtOTkyNjE4Mzc1ZTJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjI0VDIyMjYxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiNTA4ODE3MTllMTVhZmVmNWEwOGQwYjQ2YjcyYzA0NzllNDY0N2NkMTM0MzUyOGNhZmFlNDY4NjI2NGMyZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4Q7b6n0Ld_OLcZnImasEyTbvccdPvTxxiwoEMpX8taM";>
   > 
   > Instead of ` - staged-releases (source: external)`
   > 
   > we could do something like ` - staged-releases (source: settings.xml)` and 
fall back to "external" if not present.
   > 
   > and ` - run-its (source: 
org.apache.maven.plugins:maven-help-plugin:maven-plugin:4.0.0-SNAPSHOT line 
224)` if "pom".
   > 
   > I'd have to do some more testing to see if this would work.
   
   If that works, that would be even better and allow a leaner API imho.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org